[ 
https://issues.apache.org/jira/browse/HDFS-6375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14006551#comment-14006551
 ] 

Andrew Wang commented on HDFS-6375:
-----------------------------------

Hey Charles, looks good except I had a more thorough cleaning in mind when I 
suggested switching from Strings to XAttrs. ClientProtocol is still passing a 
List<String> rather than List<XAttr>, I expected it to be XAttrs everywhere 
until DFSClient where we'd turn it into a map with XAttrHelper and return the 
map keys, sort of like in getXAttrs. This should also save us writing some 
serde code (e.g. in JsonUtil).

I'll also trigger a manual test-patch.sh run to see about those test failures. 
Thanks for the rev!


> Listing extended attributes with the search permission
> ------------------------------------------------------
>
>                 Key: HDFS-6375
>                 URL: https://issues.apache.org/jira/browse/HDFS-6375
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>    Affects Versions: 3.0.0
>            Reporter: Andrew Wang
>            Assignee: Charles Lamb
>         Attachments: HDFS-6375.1.patch, HDFS-6375.2.patch, HDFS-6375.3.patch, 
> HDFS-6375.4.patch, HDFS-6375.5.patch, HDFS-6375.6.patch, HDFS-6375.7.patch
>
>
> From the attr(5) manpage:
> {noformat}
>        Users with search access to a file or directory may retrieve a list  of
>        attribute names defined for that file or directory.
> {noformat}
> This is like doing {{getfattr}} without the {{-d}} flag, which we currently 
> don't support.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to