[ https://issues.apache.org/jira/browse/HDFS-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14048741#comment-14048741 ]
Hadoop QA commented on HDFS-6609: --------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12653251/HDFS-6609.000.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 10 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:red}-1 javadoc{color}. The javadoc tool appears to have generated 2 warning messages. See https://builds.apache.org/job/PreCommit-HDFS-Build/7260//artifact/trunk/patchprocess/diffJavadocWarnings.txt for details. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:red}-1 findbugs{color}. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/7260//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/7260//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7260//console This message is automatically generated. > Use DirectorySnapshottableFeature to represent a snapshottable directory > ------------------------------------------------------------------------ > > Key: HDFS-6609 > URL: https://issues.apache.org/jira/browse/HDFS-6609 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: namenode > Reporter: Jing Zhao > Assignee: Jing Zhao > Attachments: HDFS-6609.000.patch > > > Currently we use INodeDirectorySnapshottable to represent a snapshottable > directory. When we set a directory to snapshottable, we also need to replace > the corresponding INode. It will be better to use a > DirectorySnapshottableFeature to simplify the process and get rid of the > inode replacement. -- This message was sent by Atlassian JIRA (v6.2#6252)