[ https://issues.apache.org/jira/browse/HDFS-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050745#comment-14050745 ]
Haohui Mai commented on HDFS-6609: ---------------------------------- Looks good to me. +1. > Use DirectorySnapshottableFeature to represent a snapshottable directory > ------------------------------------------------------------------------ > > Key: HDFS-6609 > URL: https://issues.apache.org/jira/browse/HDFS-6609 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: namenode > Reporter: Jing Zhao > Assignee: Jing Zhao > Attachments: HDFS-6609.000.patch, HDFS-6609.001.patch, > HDFS-6609.002.patch > > > Currently we use INodeDirectorySnapshottable to represent a snapshottable > directory. When we set a directory to snapshottable, we also need to replace > the corresponding INode. It will be better to use a > DirectorySnapshottableFeature to simplify the process and get rid of the > inode replacement. -- This message was sent by Atlassian JIRA (v6.2#6252)