[ 
https://issues.apache.org/jira/browse/HDFS-7010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14132510#comment-14132510
 ] 

Zhanwei Wang commented on HDFS-7010:
------------------------------------

hi Colin

Sorry for reply late. I'm on vocation with limited network access.

The source code in gtest and gmock directories are using google license.  Do 
you think it is better to keep them unchanged and put the google license file 
in that directories? I missed the license header in CMake files, thank you for 
pointing out.

GNU GCC recognises all of the following as C++ files, and will use C++ 
compilation regardless of whether invoke it through gcc or g++: .C, .cc, .cpp, 
.CPP, .c++, .cp, or .cxx. It is mainly a matter of taste I think. Do you think 
we can get many benefit from changing it? Changing filename extension will 
break the fault injection and many other tests in our team because our test 
framework records the filename in database and even in test case. I do not 
think it is worthy just for aligning with other code in HDFS.

Boost is needed if the GCC version is older than 4.6. After fixing HDFS-7022, 
we can support older version GCC without Boost. Maybe we can write more 
description about it. libxml2 will be changed into libexpat in HDFS-7023.


> boot up libhdfs3 project
> ------------------------
>
>                 Key: HDFS-7010
>                 URL: https://issues.apache.org/jira/browse/HDFS-7010
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client
>            Reporter: Zhanwei Wang
>         Attachments: HDFS-7010.patch
>
>
> boot up libhdfs3 project with CMake, Readme and license file.
> Integrate google mock and google test



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to