[
https://issues.apache.org/jira/browse/HDFS-7010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14143978#comment-14143978
]
Abraham Elmahrek commented on HDFS-7010:
----------------------------------------
LGTM with the exception of a couple of the ASLv2 license headers missing from:
* doxygen.in
* platform.h.in
* pretty much all of the cmake files
I'd also take a close look at doxygen inclusion in the future if this is
something the Hadoop project wants in general. My sense of things is that the
current configuration is more of a stub?
Also, on Mac, I had some difficulty building it:
{code}
CMake Error: CMake can not determine linker language for target:libhdfs3-shared
CMake Error: Cannot determine link language for target "libhdfs3-shared".
CMake Error: Cannot determine link language for target "libhdfs3-static".
CMake Error: CMake can not determine linker language for target:libhdfs3-static
{code}
I did, however, simply remove a check to build from this directory. So that
could be my fault. I worked around this by specifying
http://www.cmake.org/cmake/help/v3.0/prop_tgt/LINKER_LANGUAGE.html.
I'm not really aware of gmock or gtest... but it seems fine to me!
Thanks for working on this Colin!
> boot up libhdfs3 project
> ------------------------
>
> Key: HDFS-7010
> URL: https://issues.apache.org/jira/browse/HDFS-7010
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
> Reporter: Zhanwei Wang
> Assignee: Colin Patrick McCabe
> Attachments: HDFS-7010-pnative.003.patch, HDFS-7010.patch
>
>
> boot up libhdfs3 project with CMake, Readme and license file.
> Integrate google mock and google test
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
