[
https://issues.apache.org/jira/browse/HDFS-7010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14144001#comment-14144001
]
Colin Patrick McCabe commented on HDFS-7010:
--------------------------------------------
Added license headers to cmake files, doxygen.in, platform.h.in. Fixed
platform.h.in to have a header guard.
bq. I'd also take a close look at doxygen inclusion in the future if this is
something the Hadoop project wants in general. My sense of things is that the
current configuration is more of a stub?
Hadoop doesn't currently build doxygen for our native projects, but we should.
It's nice, basically JavaDoc for C/C++.
bq. \[Linker language comments\]
Hmm, that's odd. Hopefully using this will fix it: {{PROJECT(libhdfs3 C CXX)}}
I will make that change...
bq. I'm not really aware of gmock or gtest... but it seems fine to me!
Yeah, they are BSD-licensed libraries being bundled. gtest doesn't have a
stable API (it's mostly implemented in a header file), so it's not really
practical to link against the system version (and they explicitly tell you not
to do this). I'm not as sure about gmock, but it seems fine to bundle it for
now. It's only used for testing anyway.
> boot up libhdfs3 project
> ------------------------
>
> Key: HDFS-7010
> URL: https://issues.apache.org/jira/browse/HDFS-7010
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
> Reporter: Zhanwei Wang
> Assignee: Colin Patrick McCabe
> Attachments: HDFS-7010-pnative.003.patch,
> HDFS-7010-pnative.004.patch, HDFS-7010.patch
>
>
> boot up libhdfs3 project with CMake, Readme and license file.
> Integrate google mock and google test
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
