[
https://issues.apache.org/jira/browse/HDFS-7055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14160758#comment-14160758
]
Tsz Wo Nicholas Sze commented on HDFS-7055:
-------------------------------------------
> The findbugs warnings are not related (they're for code issues that already
> exist).
One of the findbugs warnings was from the patch as shown in the [Jenkins
report|https://builds.apache.org/job/PreCommit-HDFS-Build/8284/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html].
- Dm org.apache.hadoop.hdfs.DFSClient.<static initializer for DFSClient>()
invokes inefficient new String(String) constructor
Bug type DM_STRING_CTOR (click for details)
In class org.apache.hadoop.hdfs.DFSClient
In method org.apache.hadoop.hdfs.DFSClient.<static initializer for DFSClient>()
At DFSClient.java:\[line 3174]
{code}
private static final byte[] PATH =
new String("path").getBytes(Charset.forName("UTF-8"));
{code}
> Meanwhile diffJavacWarnings.txt is missing, so I can't evaluate where there
> is an additional warning or not.
Have you checked the later builds? The
[diffJavacWarnings.txt|https://builds.apache.org/job/PreCommit-HDFS-Build/8284/artifact/patchprocess/diffJavacWarnings.txt]
file was available. The javac warnings were indeed from the patch.
> Add tracing to DFSInputStream
> -----------------------------
>
> Key: HDFS-7055
> URL: https://issues.apache.org/jira/browse/HDFS-7055
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode, namenode
> Affects Versions: 2.6.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Fix For: 2.7.0
>
> Attachments: HDFS-7055.002.patch, HDFS-7055.003.patch,
> HDFS-7055.004.patch, HDFS-7055.005.patch, screenshot-get-1mb.005.png,
> screenshot-get-1mb.png
>
>
> Add tracing to DFSInputStream.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
