[
https://issues.apache.org/jira/browse/HDFS-7055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14167209#comment-14167209
]
Tsz Wo Nicholas Sze commented on HDFS-7055:
-------------------------------------------
One more findbugs warning from the patch:
- Dodgy code Warnings
NP Dereference of the result of readLine() without nullcheck in
org.apache.hadoop.tracing.SpanReceiverHost.getUniqueLocalTraceFileName()
Bug type NP_DEREFERENCE_OF_READLINE_VALUE (click for details)
In class org.apache.hadoop.tracing.SpanReceiverHost
In method
org.apache.hadoop.tracing.SpanReceiverHost.getUniqueLocalTraceFileName()
Value loaded from line
At SpanReceiverHost.java:\[line 104]
[~cmccabe], I think you need to be more serious on verifying the warnings
before committing patches.
> Add tracing to DFSInputStream
> -----------------------------
>
> Key: HDFS-7055
> URL: https://issues.apache.org/jira/browse/HDFS-7055
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode, namenode
> Affects Versions: 2.6.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Fix For: 2.7.0
>
> Attachments: HDFS-7055.002.patch, HDFS-7055.003.patch,
> HDFS-7055.004.patch, HDFS-7055.005.patch, screenshot-get-1mb.005.png,
> screenshot-get-1mb.png
>
>
> Add tracing to DFSInputStream.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
