[ 
https://issues.apache.org/jira/browse/HDFS-7055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14167316#comment-14167316
 ] 

Tsz Wo Nicholas Sze commented on HDFS-7055:
-------------------------------------------

{quote}
> Colin Patrick McCabe, I think you need to be more serious on verifying the 
> warnings before committing patches.

That warning did not appear in the newPatchFindbugsWarnings file:

https://builds.apache.org/job/PreCommit-HDFS-Build/8284//artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
{quote}
It won't be on the hdfs findbugs output file since this findbugs warning is in 
common.

Why there was no Common findbugs output file?  It was because the patch 
committed by HDFS-6956 (also contributed and committed by [~cmccabe]) broke 
findbugsExcludeFile.xml in common.

Colin, I just want to give you a friendly reminder that we all should make sure 
the patches are all good (no javac/findbugs warnings, didn't break the build, 
etc.) before committing them.  Hope that you won't mind.

> Add tracing to DFSInputStream
> -----------------------------
>
>                 Key: HDFS-7055
>                 URL: https://issues.apache.org/jira/browse/HDFS-7055
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode, namenode
>    Affects Versions: 2.6.0
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>             Fix For: 2.7.0
>
>         Attachments: HDFS-7055.002.patch, HDFS-7055.003.patch, 
> HDFS-7055.004.patch, HDFS-7055.005.patch, screenshot-get-1mb.005.png, 
> screenshot-get-1mb.png
>
>
> Add tracing to DFSInputStream.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to