On Thursday 29 March 2012 01:18 PM, Vojtech Horky wrote:
Hi Balaji,
Hi Vojtech,
thanks for the patch.
Thanks for the review!
Dne 26. března 2012 21:27 Balaji Rao<[email protected]> napsal(a):
Next, I started looking at the open tickets. The one "mkfat.py does not
support LFN" sounded fun and quickly doable. After hacking on it for a few
hours, I managed to complete it. I've included the patch as an attachment
and inline (doesn't this make commenting easier ?) I've tested it on Helenos
and both msdos and vfat filesystems of Linux.
I just tried it and unfortunately it does not work for me out of the
box. However after I fixed several minor issues (see inline comments
in the patch), I was able to build the FAT image and it worked.
Thanks!
I'm sorry, my bad! These are cosmetic changes I made at the last minute before
sending the patch. My bad I didn't test it!
I hope someone else will carry-on and add support for national characters.
Oh you're talking about the problem of creating SFN when the given filename has
unicode characters ?
Below are the patch excerpts with comments
=== modified file 'tools/mkfat.py'
--- tools/mkfat.py 2011-07-24 21:18:16 +0000
+++ tools/mkfat.py 2012-03-26 18:44:46 +0000
+
+def get_utf16(name, l) :
+ "Create a int array out of a string which we can
+ store in uint16_t arrays"
This causes parsing error. For multiline comments you shall use """.
+ csum = 0
+ for i in range(0, 11) :
+ csum = ((sum& 1)<< 7) + (sum>> 1) + ord(fname11[i])
+ csum = sum& 0xFF
+
+ for e in entries :
+ e.csum = sum;
Few typos here (sum -> csum). I wonder which version of Python you are
using that it worked for you ;-).
Lol! Sorry :(
Best,
Balaji
_______________________________________________
HelenOS-devel mailing list
[email protected]
http://lists.modry.cz/cgi-bin/listinfo/helenos-devel
