Hi Balaji,
Dne 29. března 2012 10:21 Balaji Rao <[email protected]> napsal(a):
> On Thursday 29 March 2012 01:18 PM, Vojtech Horky wrote:
>>
>> Hi Balaji,
>
>
> Hi Vojtech,
>
>> thanks for the patch.
>>
>
> Thanks for the review!
No problem. I already applied your patch to my branch [1] and it will
be merged soon.
>> I hope someone else will carry-on and add support for national characters.
>>
>
> Oh you're talking about the problem of creating SFN when the given filename
> has
> unicode characters ?
Yes. The problem is that
dir_entry.name = dir_entry.name.upper().encode('ascii')
may not work for all characters. You have to add the 'ignore' option
but then you may end with empty filename. I haven't look yet into doc
how the algorithm for mangling shall deal with this.
Again, thanks for the patch.
- Vojta
[1] https://code.launchpad.net/~vojtech-horky/helenos/misc
>
>>
>> Below are the patch excerpts with comments
>>>
>>>
>>> === modified file 'tools/mkfat.py'
>>> --- tools/mkfat.py 2011-07-24 21:18:16 +0000
>>> +++ tools/mkfat.py 2012-03-26 18:44:46 +0000
>>> +
>>> +def get_utf16(name, l) :
>>> + "Create a int array out of a string which we can
>>> + store in uint16_t arrays"
>>
>> This causes parsing error. For multiline comments you shall use """.
>>
>>> + csum = 0
>>> + for i in range(0, 11) :
>>> + csum = ((sum& 1)<< 7) + (sum>> 1) + ord(fname11[i])
>>> + csum = sum& 0xFF
>>>
>>> +
>>> + for e in entries :
>>> + e.csum = sum;
>>
>> Few typos here (sum -> csum). I wonder which version of Python you are
>> using that it worked for you ;-).
>
>
> Lol! Sorry :(
>
> Best,
> Balaji
>
>
>
> _______________________________________________
> HelenOS-devel mailing list
> [email protected]
> http://lists.modry.cz/cgi-bin/listinfo/helenos-devel
_______________________________________________
HelenOS-devel mailing list
[email protected]
http://lists.modry.cz/cgi-bin/listinfo/helenos-devel
