On Saturday 31 March 2012 11:13 PM, Vojtech Horky wrote:
Hi Balaji, Dne 29. března 2012 10:21 Balaji Rao<[email protected]> napsal(a):On Thursday 29 March 2012 01:18 PM, Vojtech Horky wrote:Hi Balaji,Hi Vojtech,thanks for the patch.Thanks for the review!No problem. I already applied your patch to my branch [1] and it will be merged soon.
Thanks!
I hope someone else will carry-on and add support for national characters.Oh you're talking about the problem of creating SFN when the given filename has unicode characters ?Yes. The problem is that dir_entry.name = dir_entry.name.upper().encode('ascii') may not work for all characters. You have to add the 'ignore' option but then you may end with empty filename. I haven't look yet into doc how the algorithm for mangling shall deal with this.
I was looking exactly at that. I noticed that if I remove the encode('ascii')
thing, and feed it with non-ascii filenames, it still goes through. Is xstruct
possiblydoing some kind of encoding ?
I noticed that linux just adds a '?' character for national characters. The
param
'replace' in the encode method apparently does this, but couldn't get it to
work.
Will give it another go.
Again, thanks for the patch.
Sure! -- Best, Balaji Rao _______________________________________________ HelenOS-devel mailing list [email protected] http://lists.modry.cz/cgi-bin/listinfo/helenos-devel
