Hi Aurelio,
On 02/24/2016 10:39 PM, Aurelio Colosimo wrote:
> I think I've reached a first result about ticket #466, which I'm
> attaching here in the form of a bazaar directive containing 5 patches.
> It's the first time I use bazaar, I hope I understood how to do. Also, I
> hope I respected your coding standard; please tell me if not, and I'll
> re-adapt my patches.
The merge directive works as expected, your change history is in there
:-) The coding standard looks good too, with two nits:
+NO_TRACE static const char *cmdtab_enum(const char *name,
+ const char **h, void **ctx)
{
+ link_t **startpos = (link_t**)ctx;
The last line is not a continuation line, so it should come with a TAB
instead of four spaces.
The second nit is that sometimes you omit whitespace around *, for
example here:
+ const char*(*hints_enum)(const char *, const char **, void **);
> Briefly, the current status of kconsole tab completion is:
> - unique src code for all completion routines (including command tab
> itself);
> - enum callback infrastructure implemented;
> - enum callback function implemented for commands, "call*" command
> arguments and for "test" arguments.
>
> Next step should be arguments completion for all available commands;
> before proceeding, I'd like to be sure that I'm on the right direction.
There is also another nit I noticed. It looks like it was not caused by
your improvement, but anyway, if you tab-complete zone<TAB> and then
continue pressing TAB, you will not see an option to complete to zones
and there will be no new line, so the command line will become
distorted. I think this is a corner case, because zone is a prefix of
zones and this situation is not handled well.
Your direction seems good to me, I haven't inspected your change
line-by-line yet though.
Best,
Jakub
_______________________________________________
HelenOS-devel mailing list
[email protected]
http://lists.modry.cz/listinfo/helenos-devel
