Hi Aurelio,
Hi Jacub, here below my inline answers.
The merge directive works as expected, your change history is in there
:-) The coding standard looks good too, with two nits:
+NO_TRACE static const char *cmdtab_enum(const char *name,
+ const char **h, void **ctx)
{
+ link_t **startpos = (link_t**)ctx;
The last line is not a continuation line, so it should come with a TAB
instead of four spaces.
Please can you explain what do you mean for a "continuation line"? It
seemed to me that, normally, "const char **h" would go on the previous
line, but I'm "continuing" the parameters list in the line below, that's
why I used spaces.
The second nit is that sometimes you omit whitespace around *, for
example here:
+ const char*(*hints_enum)(const char *, const char **, void **);
Ok, I will check and fix them. About this specific function pointer, I
wonder whether you prefer a typedef for it, e.g.:
typedef const char *(*hints_enum_func_t)(const char *, const char **,
void **);
There is also another nit I noticed. It looks like it was not caused by
your improvement, but anyway, if you tab-complete zone<TAB> and then
continue pressing TAB, you will not see an option to complete to zones
and there will be no new line, so the command line will become
distorted. I think this is a corner case, because zone is a prefix of
zones and this situation is not handled well.
I've just checked, I understand what you mean, though I can see this bug
was there also before my patches; I may try to deal with it when I'm
done with the #466 feature itself.
Your direction seems good to me, I haven't inspected your change
line-by-line yet though.
Ok, so I think I will go on working on it, then I will propose another
set of patches, implementing the complete feature, to be applied in
place of the ones I sent last week.
Thank you so much
Aurelio
_______________________________________________
HelenOS-devel mailing list
[email protected]
http://lists.modry.cz/listinfo/helenos-devel
