Hi Jasha, I understand your point, but I think that our editors want to be able to fix spelling issues without the poll resetting. I don't expect the editors to understand why the poll is being reset (or even that it has been), especially since there is no warning. So at the very least, I consider this lack of warning to be unacceptable/a bug.
However, I would like to argue that wrong voting results are the responsibility
of the poll editor. Having a new answer start at 0 votes seems completely
sensible to me, for example. Changing an answer and having the votes stay the
same is also expected behaviour (in my mind at least). The poll editor should
decide whether that is acceptable to him. If it isn't, he can always create a
new poll. Note that the editor can also change his mind and remove the answer
again (or change the answer back), so he can undo his mistake.
In summary, the advantages of this change are:
- No unexpected data loss that cannot be undone by the editor
- Spelling fixes are possible
- 'Dangerous' changes have expected results and can be safely undone
Regards,
Wouter
-----Original Message-----
From: [EMAIL PROTECTED] on behalf of Jasha Joachimsthal
Sent: Tue 1/8/2008 12:56 PM
To: Hippo CMS development public mailinglist
Subject: RE: Poll change erases votes
Hi Wouter,
you can discuss about this being a bug or (un)wanted behaviour. If you change
the poll, the answers or the question may change which is a reason to reset the
answers. Otherwise you'd display voting results for answers the voters have not
responded to. This is the reason why we implemented a separate function to
toggle the online status so that the question and answers are untouched.
Jasha
-----Original Message-----
From: [EMAIL PROTECTED] on behalf of Wouter Zelle
Sent: Tue 1/8/2008 12:49
To: Hippo CMS development public mailinglist
Subject: Poll change erases votes
Hi,
I've found another bug in the Poll. If you edit the poll in the CMS, the votes
are erased. The problem seems to be that the Answer Id's are not properly used
in the form. The result is that new Answer-objects are created (and saved in
the DB).
I've fixed the issue by making this change in insertPoll.bnd.xml:
<fb:value id="id" path="answerId"/> -> <fb:value id="id" path="id"/>
and changing the following lines in insertPoll.bnd.xml:
<fd:field id="id" required="false">
<fd:label>ID</fd:label>
<fd:datatype base="integer">
<fd:convertor type="plain"/>
</fd:datatype>
</fd:field>
to:
<fd:field id="id" required="false">
<fd:label>ID</fd:label>
<fd:datatype base="integer"/>
</fd:field>
Regards,
Wouter Zelle
<<winmail.dat>>
******************************************** Hippocms-dev: Hippo CMS development public mailinglist
