[
https://issues.apache.org/jira/browse/HIVE-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12891513#action_12891513
]
Bennie Schut commented on HIVE-1126:
------------------------------------
John,
I think the spec is pretty clear on this:
http://download.oracle.com/docs/cd/E17476_01/javase/1.3/docs/guide/jdbc/spec/jdbc-spec.frame9.html
We are supposed to make it thread safe. Now they explain that the most logical
use case for multi threading on a single connection would be the cancel call.
What squirrel is doing might be unexpected but it is allowed per spec. A
separate JIRA would make sense since this isn't the only spot I guess.
I'll remove the sync for now.
I've changed all things Carl said except for the copying the input lists. These
lists are explicitly created to be used on this resultset only and can't
possibly be modified by anything. I think I should have made them final like
this:
public HiveMetaDataResultSet(final List<String> columnNames
, final List<String> columnTypes
Which would make this clear. However if anyone feels strongly about having this
copied by value then I'll change that to.
You can expect a new patch in a few minutes.
Bennie.
> Missing some Jdbc functionality like getTables getColumns and
> HiveResultSet.get* methods based on column name.
> --------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-1126
> URL: https://issues.apache.org/jira/browse/HIVE-1126
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Clients
> Affects Versions: 0.7.0
> Reporter: Bennie Schut
> Assignee: Bennie Schut
> Fix For: 0.7.0
>
> Attachments: HIVE-1126-1.patch, HIVE-1126-2.patch, HIVE-1126.patch,
> HIVE-1126_patch(0.5.0_source).patch
>
>
> I've been using the hive jdbc driver more and more and was missing some
> functionality which I added
> HiveDatabaseMetaData.getTables
> Using "show tables" to get the info from hive.
> HiveDatabaseMetaData.getColumns
> Using "describe tablename" to get the columns.
> This makes using something like SQuirreL a lot nicer since you have the list
> of tables and just click on the content tab to see what's in the table.
> I also implemented
> HiveResultSet.getObject(String columnName) so you call most get* methods
> based on the column name.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
