[
https://issues.apache.org/jira/browse/HIVE-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12890434#action_12890434
]
John Sichi commented on HIVE-1126:
----------------------------------
Hey, thanks a lot Bennie! I know a lot of people are looking forward to this
one.
I have a couple of cosmetic items which need to be fixed and then we can commit
this:
* JdbcColumn.java and JdbcTable.java: please add Apache file header to these
two new files
* HiveDatabaseMetaData.java: replace import java.util.* with expanded imports
(Hive convention)
Questions:
* In HiveDatabaseMetaData.getTables, why did you need to make one of the blocks
synchronized?
* why does supportsNamedParameters return true?
For the HiveResultSet getters (e.g. getLong), they are actually supposed to
attempt a conversion (e.g. if the column is string, attempt convert to long).
It's OK to just throw exception for now, but maybe the message should be
"Unsupported conversion" instead of "Illegal conversion"?
Regarding catalog/schema, I agree with Carl that we should try to mimic MySQL
here.
> Missing some Jdbc functionality like getTables getColumns and
> HiveResultSet.get* methods based on column name.
> --------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-1126
> URL: https://issues.apache.org/jira/browse/HIVE-1126
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Clients
> Affects Versions: 0.7.0
> Reporter: Bennie Schut
> Assignee: Bennie Schut
> Priority: Minor
> Fix For: 0.7.0
>
> Attachments: HIVE-1126-1.patch, HIVE-1126-2.patch, HIVE-1126.patch,
> HIVE-1126_patch(0.5.0_source).patch
>
>
> I've been using the hive jdbc driver more and more and was missing some
> functionality which I added
> HiveDatabaseMetaData.getTables
> Using "show tables" to get the info from hive.
> HiveDatabaseMetaData.getColumns
> Using "describe tablename" to get the columns.
> This makes using something like SQuirreL a lot nicer since you have the list
> of tables and just click on the content tab to see what's in the table.
> I also implemented
> HiveResultSet.getObject(String columnName) so you call most get* methods
> based on the column name.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
