[
https://issues.apache.org/jira/browse/HIVE-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12891524#action_12891524
]
Carl Steinbach commented on HIVE-1126:
--------------------------------------
bq. I've changed all things Carl said except for the copying the input lists.
These lists are explicitly created to be used on this resultset only and can't
possibly be modified by anything. I think I should have made them final like
this
In Java a final variable can only be assigned to once. Making a variable final
does not make it immutable, and making the constructor parameters columnNames
and columnTypes final won't prevent the caller from later mutating these lists
and affecting the internal state of the ResultSet object. I think it's prudent
to make this change now since it's hard to anticipate how this class will be
used in the future.
> Missing some Jdbc functionality like getTables getColumns and
> HiveResultSet.get* methods based on column name.
> --------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-1126
> URL: https://issues.apache.org/jira/browse/HIVE-1126
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Clients
> Affects Versions: 0.7.0
> Reporter: Bennie Schut
> Assignee: Bennie Schut
> Fix For: 0.7.0
>
> Attachments: HIVE-1126-1.patch, HIVE-1126-2.patch, HIVE-1126-3.patch,
> HIVE-1126.patch, HIVE-1126_patch(0.5.0_source).patch
>
>
> I've been using the hive jdbc driver more and more and was missing some
> functionality which I added
> HiveDatabaseMetaData.getTables
> Using "show tables" to get the info from hive.
> HiveDatabaseMetaData.getColumns
> Using "describe tablename" to get the columns.
> This makes using something like SQuirreL a lot nicer since you have the list
> of tables and just click on the content tab to see what's in the table.
> I also implemented
> HiveResultSet.getObject(String columnName) so you call most get* methods
> based on the column name.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
