[ 
https://issues.apache.org/jira/browse/HIVE-1534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated HIVE-1534:
------------------------------------------

    Attachment: patch-1534-2.txt

bq. What about semi joins ? 
I did not find anything wrong with semijoin queries and filters. They can be 
pushed as they are now. I don't think any change is required for semi joins. 
What do you think?

Uploading patch with following changes from earlier one:
* I think it makes sense to push the filters on partitioned columns and not 
output all the table for outer join. Patch pushes filters on partitioned 
columns, even for outer joins. Thoughts?
* Removed duplicate code in genExprNode() in SemanticAnalyzer.
* Fixed some minor bugs in SemanticAnalyzer and CommonJoinOperator, found in 
the test failures.
* Updated the test results for clientpositive queries in join20.q.out, 
join21.q.out and join40.q.out, which involve filters on outer joins. Also, 
updated test results for TestParse join queries.

All the tests passed with the uploaded patch.


> Join filters do not work correctly with outer joins
> ---------------------------------------------------
>
>                 Key: HIVE-1534
>                 URL: https://issues.apache.org/jira/browse/HIVE-1534
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Amareshwari Sriramadasu
>         Attachments: patch-1534-1.txt, patch-1534-2.txt, patch-1534.txt
>
>
>  SELECT * FROM T1 LEFT OUTER JOIN T2 ON (T1.c1=T2.c2 AND T1.c1 < 10)
> and  SELECT * FROM T1 RIGHT OUTER JOIN T2 ON (T1.c1=T2.c2 AND T2.c1 < 10)
> do not give correct results.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to