[ 
https://issues.apache.org/jira/browse/HIVE-1534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12912831#action_12912831
 ] 

Amareshwari Sriramadasu commented on HIVE-1534:
-----------------------------------------------

bq. This is a incompatible change, and will change/break existing queries.
The patch changes the query results to be different from what it was earlier. 
It does not give out any error, unlike HIVE-1621.  The effect is similar to 
HIVE-741.  I don't think this is incompatible change, because the current query 
results are wrong and the issue fixes the correctness.

If you still think it is incompatible change, we can add a configuration like 
hive.outerjoin.supports.filters with following semantics:
# when it is off,  print a warning saying "the results could be wrong. please 
turn on  hive.outerjoin.supports.filters" and add it to filtersForPushing (same 
as old behavior).
# When it is on, the filters are added to join filters.


> Join filters do not work correctly with outer joins
> ---------------------------------------------------
>
>                 Key: HIVE-1534
>                 URL: https://issues.apache.org/jira/browse/HIVE-1534
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Amareshwari Sriramadasu
>         Attachments: patch-1534-1.txt, patch-1534-2.txt, patch-1534-3.txt, 
> patch-1534.txt
>
>
>  SELECT * FROM T1 LEFT OUTER JOIN T2 ON (T1.c1=T2.c2 AND T1.c1 < 10)
> and  SELECT * FROM T1 RIGHT OUTER JOIN T2 ON (T1.c1=T2.c2 AND T2.c1 < 10)
> do not give correct results.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to