On Mon, Oct 18, 2004 at 08:02:33AM -0400, David Fencik wrote:
> Now that I think about it...the "buffer overflow" problem is most likely
> caused by the data in the "file read buffer" growing too large, not on
> any restrictions placed on the list of bans.

Agreed.

> As voogru stated, the most efficient and obvious way for the engine to
> store the bans is in a linked list.  It would also be terrible if that
> list weren't sorted.

A linked list would be very inefficient when searching a specific ID in
the list. It would be better to use a hash or tree structure. (I don't
know what Valve uses for ban lists..)

> I'm thinking that the engine reads the file into a buffer and then
> builds the list from there.  There could either be a bug in the banlist
> parser function, or maybe it is not coded intelligently enough to handle
> a file larger than the buffer.

Maarten

--
A: Because it fouls the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing on usenet and in e-mail?

_______________________________________________
To unsubscribe, edit your list preferences, or view the list archives, please visit:
http://list.valvesoftware.com/mailman/listinfo/hlds

Reply via email to