[ http://issues.apache.org/jira/browse/HTTPCORE-13?page=comments#action_12437565 ] Oleg Kalnichevski commented on HTTPCORE-13: -------------------------------------------
> - define an interface for processing requests and responses > - turn AbstractHttpProcessor into DefaultHttpProcessor, make processing > methods public > - move default implementation to an implementation package > - HttpRequestExecutor and HttpService can no longer derive from > DefaultHttpProcessor, > since it is in an implementation package Makes sense. Wouldn 't HttpInterceptorChain be a better name for this interface, though? > Observation: HttpService is in an API package but imports and instantiates > two implementation classes. > Maybe we should reconsider the whole protocol package with respect to API vs. > implementation. You are right. This needs to be fixed Oleg > AbstractHttpProcessor is not really abstract > -------------------------------------------- > > Key: HTTPCORE-13 > URL: http://issues.apache.org/jira/browse/HTTPCORE-13 > Project: HttpComponents Core > Issue Type: Improvement > Components: HttpCore > Affects Versions: 4.0-alpha3 > Reporter: Roland Weber > Assigned To: Roland Weber > Priority: Minor > Attachments: 2k6-09-25-core-proc-1.txt > > > AbstractHttpProcessor is declared abstract though it does not have any > abstract method. This artificially restricts use of the base class > functionality to subclassing and prohibits use by reference. That is one of > the reasons why HttpAsync has an ugly AsyncHttpProcessor class. > Patch follows. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
