[
http://issues.apache.org/jira/browse/HTTPCORE-13?page=comments#action_12437664
]
Oleg Kalnichevski commented on HTTPCORE-13:
-------------------------------------------
Roland,
I still somehow can't help feeling that HttpProcessor is not a very appropriate
name for this interface. Would the following changes be okay with you?
Rename: HttpProcessor -> HttpProtocolHandler
Rename: DefaultHttpProcessor -> o.a.http.protocol.BasicHttpProtocolHandler
Add: class o.a.http.protocol.HttpClientProtocolHandler extends
o.a.http.protocol.BasicHttpProtocolHandler {
public HttpClientProtocolHandler() {
super();
addInterceptor(new RequestContent());
addInterceptor(new RequestTargetHost());
addInterceptor(new RequestConnControl());
addInterceptor(new RequestUserAgent());
addInterceptor(new RequestExpectContinue());
}
}
Add: class o.a.http.protocol.HttpServerProtocolHandler extends
o.a.http.protocol.BasicHttpProtocolHandler {
public HttpClientProtocolHandler() {
super();
addInterceptor(new ResponseDate());
addInterceptor(new ResponseServer());
addInterceptor(new ResponseContent());
addInterceptor(new ResponseConnControl());
}
}
> AbstractHttpProcessor is not really abstract
> --------------------------------------------
>
> Key: HTTPCORE-13
> URL: http://issues.apache.org/jira/browse/HTTPCORE-13
> Project: HttpComponents Core
> Issue Type: Improvement
> Components: HttpCore
> Affects Versions: 4.0-alpha3
> Reporter: Roland Weber
> Assigned To: Roland Weber
> Priority: Minor
> Attachments: 2k6-09-25-core-proc-1.txt
>
>
> AbstractHttpProcessor is declared abstract though it does not have any
> abstract method. This artificially restricts use of the base class
> functionality to subclassing and prohibits use by reference. That is one of
> the reasons why HttpAsync has an ugly AsyncHttpProcessor class.
> Patch follows.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
