[ 
http://issues.apache.org/jira/browse/HTTPCORE-13?page=comments#action_12437598 
] 
            
Roland Weber commented on HTTPCORE-13:
--------------------------------------

Hi Oleg,

> Wouldn 't HttpInterceptorChain be a better name for this interface, though?

The interface in the patch makes no reference to interceptors except in the 
JavaDoc.
If we include methods to add/remove interceptors to the interface, I agree.
Right now, those methods are only in the implementation class.
I think we'll have more of them in the future (like index-based ones),
and I am reluctant to add the full selection to the interface.
Read-only is enough for both request executor and service.

cheers,
  Roland


> AbstractHttpProcessor is not really abstract
> --------------------------------------------
>
>                 Key: HTTPCORE-13
>                 URL: http://issues.apache.org/jira/browse/HTTPCORE-13
>             Project: HttpComponents Core
>          Issue Type: Improvement
>          Components: HttpCore
>    Affects Versions: 4.0-alpha3
>            Reporter: Roland Weber
>         Assigned To: Roland Weber
>            Priority: Minor
>         Attachments: 2k6-09-25-core-proc-1.txt
>
>
> AbstractHttpProcessor is declared abstract though it does not have any 
> abstract method. This artificially restricts use of the base class 
> functionality to subclassing and prohibits use by reference. That is one of 
> the reasons why HttpAsync has an ugly AsyncHttpProcessor class.
> Patch follows.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to