Is here someone, who can check the following inconsistencies in the source
code?
1.) pano_modify.exe calculate a wrong (vertical?) FoV.
%HUGINSDK%/hugin-hg/src/hugin_base/algorithms/nona/CalculateFOV.cpp
function hugin_utils::FDiff2D CalculateFOV::calcFOV(const PanoramaData&
panorama):
if(fov.x<40)
{
fov.x+=1;
fov.y+=1; // [BD] I add this line, so that y is equal to x treated
};
return fov;
fov.x and fov.y must be calculated equivalent. What reason is there for the
if statement? The gap at 40.0 make no sense. It looks like a dirty trick to
bend the correct result to a desired result. I use always fov < 4, then it
seems to work better with +1. But this is only a subjective impression.
2.)
%HUGINSDK%\libpano-hg\math.c
function tiltForward:
s = z1 / z0;
s = z0 /(x_dest * (-sin(phi2)/cos(phi2)) + y_dest * sin(phi)/cos(phi
) + z0);
The first calculation of s is unused. Perhaps an unnoticed error.
Kind regards,
Bernd
--
A list of frequently asked questions is available at:
http://wiki.panotools.org/Hugin_FAQ
---
You received this message because you are subscribed to the Google Groups
"hugin and other free panoramic software" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/hugin-ptx/518027c7-918e-4ef0-b31d-5955f3b7e01a%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
