On Sunday, February 20, 2022 at 10:55:26 AM UTC-5 T. Modes wrote:
> > I asked you several times not to mix up several things in one commit. You > still mixed up several unrelated code changes in one changeset. (Yes, they > have both the same target. But the code changes are totally unrelated. And > the commit message say nothing if somebody looks later in the history.) > I don't see how it is "several" unrelated changes. There is the minor change (that in hindsight I should not have done, because it was separable and because you made the same change between when I tested and when I committed and I failed to notice that when committing). But all the rest is one unit and I can't see how it could be split. I also can't think of what a better commit message might be. > > Yes, it builds and the memory consumptions is reduced. But at the same > time the CPU usage increased significant. When scrolling a single image the > CPU usage increases on my system to nearly 100 %! > And the synchronized scrolling of both images is broken - in the default > branch it takes 3-4 % CPU for a single image scrolling and 6-7 % for the > synchronized scrolling. > My system was always cpu bound when scrolling that window (not reported as 100% because it isn't multi-threaded enough to report as 100%) and my version is faster on my system. I have tried to guess how it might behave on other systems, but apparently something is happening on your system that I didn't predict. How many cores does your CPU have and what tool did you use to measure that 100%? I will investigate the issue with synchronized scrolling. There are a number of different ways to compromise the change for potentially better CPU performance and worse (but still better than original) memory use. But I would need better feedback. It is also possible to get another large performance increase by mixing the scaling into the subimage extraction, rather than using the slower more general version in wxImage. -- A list of frequently asked questions is available at: http://wiki.panotools.org/Hugin_FAQ --- You received this message because you are subscribed to the Google Groups "hugin and other free panoramic software" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/hugin-ptx/a0d2dece-ebc0-4b1f-9e58-2c17f8c0b4f1n%40googlegroups.com.
