The bitmap branch looks good to me. There might still be some documentation/comments to update, but nothing big. Given how intrusive this branch is, I'd rather merge it early instead of fixing conflicts in other branches for a long time :)
What I need first is somebody to check my pragma at the end of src/cpuset.c https://svn.open-mpi.org/trac/hwloc/browser/branches/bitmap/src/cpuset.c Brice Le 24/09/2010 14:35, Jeff Squyres a écrit : > Sounds good. > > On Sep 24, 2010, at 7:30 AM, Brice Goglin wrote: > > >> Here's a proposal for the new renamed cpuset API. Non trivial changes >> include: >> hwloc_cpuset_from_string -> hwloc_bitmap_sscanf >> hwloc_cpuset_cpu -> hwloc_bitmap_setonly >> hwloc_bitmap_all_but_cpu -> hwloc_bitmap_allbut >> >> My plan would be to: >> * commit the attached file as hwloc/bitmap.h >> * drop everything from hwloc/cpuset.h, add a big deprecation warning in >> the header, make it include bitmap.h, and add typedef/#define for API >> backward compat >> * port all the internals to the new API >> * only #include bitmap.h internally >> * add ABI aliases at the end of src/cpuset.c (don't know if it's worth >> renaming this file) >> >> By the way, what's the proper way to do the latter? >> #pragma weak hwloc_cpuset_foo = hwloc_bitmap_foo ? >> use __hwloc_attribute_alias instead ? >> >> Brice >> >> <cpuset.h>_______________________________________________ >> hwloc-devel mailing list >> hwloc-de...@open-mpi.org >> http://www.open-mpi.org/mailman/listinfo.cgi/hwloc-devel >> > >
