what do we do then ? I propose to : - revert merge of #PR846 - reset --hard ac713f14 - merge #PR846
I'll push branches jeyzu-xsd / jeyzu-xdg / jeyzu-dsysata On Thursday 23 April 2020 21:59, mau...@smoors.de wrote : > Am 23.04.2020 16:17, schrieb Jérémy Zurcher: > > Hi ! > > > > On Wednesday 22 April 2020 22:40, Przemysław Sitek wrote : > > > > > > > I welcome syntax changes - renaming root node from <drumkit_info> to > > > simply <drumkit>, and <meta> element. The new format is certainly > > > nicer, but I don’t feel confident that now, after two betas had been > > > released, is the best moment to change our file formats. Especially > > > after Ubuntu Studio guys agreed to package beta1 in LTS release as > > > long as we refrain from making breaking changes;) I’d like to know > > > what others think. > > > > > changes are so little and legacy loading is untouched ... > > I'm also sceptical about this change. On the one hand, i can see that the > drumkit_info might be not an ideal root element of the xml and that Hydrogen > 1.0 might be a good oppertunity to introduce larger changes. On the other > hand, that file is read by machines and the change is only of cosmetical > nature (if i understand it correctly). There are a lot of scripts around > that work on drumkit files (for example creating drumkits by reading in a > directory of samples), and also other applications which work with h2drumkit > files. This change will break these applications. Considering this, i would > try to avoid to change the file format just for the "looks". Of course this > does not apply to the "version" attribute, this is very much needed! > > > > > > > > btw. > > > > if everything goes as expected, my http://www.czarciekopyto.com/en > > > > will be delivered to me on friday ... huummm ! > > > > (I've ordered it weeks before what we're living ... ) > > > > > > > > I'll be happy kicking ! > > > > > > Man, that rocks! That's probably the coolest drum pedal of all > > > times! I’ve dreamt about that pedal for years, and I don’t even play > > > drums:) I’m sure you’ll have a great time! > > > > I have it, it's very impressive, will test it in a few hours. > > > > I'm awaiting a review from you in some weeks :) I've tried my first "newer" > pedal some weeks ago (Tama Speedcobra 910), but i couldn't get used to it > until now. Went back to my old DW 5000 for the moment.. > Have fun with that masterpiece! > > Best regards, > Sebastian > > > _______________________________________________ > Hydrogen-devel mailing list > Hydrogen-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/hydrogen-devel ----------------------- Jérémy Zurcher rue des Charmilles 7 1400 Yverdon-les-bains +41 (0) 79 599 84 27 _______________________________________________ Hydrogen-devel mailing list Hydrogen-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/hydrogen-devel