I'm concerned that this is not the friendliest of new APIs. There is
little description of the meaning of the ISO-3166 parts - what is
being added is directly exposing the underlying data rather than
providing any kind of abstraction.

There is also an inconsistency between "ISO" and "Iso" in the class/method names

Stephen


On 29 November 2016 at 09:07, Rachna Goel <rachna.g...@oracle.com> wrote:
> Hi,
>
> Please review fix for JDK-8071929.
>
> Bug : https://bugs.openjdk.java.net/browse/JDK-8071929
>
> patch : http://cr.openjdk.java.net/~rgoel/JDK_8071929/webrev.02/
>
> Fix is to remove obsolete country code "AN" and provide support for
> retrieving of ISO3166-1 alpha-2,  ISO3166-1 alpha-3, ISO3166-3 country
> codes.
>
> Thanks,
> Rachna
>

Reply via email to