On Thu, 21 Apr 2022 08:35:36 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
> I ran `codespell` on the `src/java.desktop` directory, and accepted those
> changes where it indeed discovered real typos.
>
> I ignored typos in public methods and variables. Maybe they can be fixed
> later on without much fanfare, if they are in internal classes. Typos in
> exposed APIs are likely here to stay.
>
> I will update copyright years using a script before pushing (otherwise like
> every second change would be a copyright update, making reviewing much
> harder).
>
> The long term goal here is to make tooling support for running `codespell`.
> The trouble with automating this is of course all false positives. But before
> even trying to solve that issue, all true positives must be fixed. Hence this
> PR.
static class AquaHierarchyButtonListener implements HierarchyListener {
- // Everytime a hierarchy is change we need to check if the button if
moved on or from
+ // Every time a hierarchy is change we need to check if the button if
moved on or from
change -> changed
if moved -> is moved
src/java.desktop/macosx/classes/sun/lwawt/macosx/CEmbeddedFrame.java
- // it won't be invoced if focuse is moved to a html element
+ // it won't be invoced if focus is moved to a html element
invoced -> invoked
"a html" -> "an html"
src/java.desktop/macosx/native/libjsound/PLATFORM_API_MacOSX_MidiOut.c
+ // $$fb 2002-04-04: It is responsibility of the application developer to
"is the"
src/java.desktop/windows/native/libjsound/PLATFORM_API_WinOS_MidiOut.c
+ // $$fb 2002-04-04: It is responsibility of the application developer to
same as above
Regarding changes in gif + freetype
diff --git a/src/java.desktop/share/native/libawt/awt/image/gif/gifdecoder.c
b/src/java.desktop/share/native/libawt/awt/image/gif/gifdecoder.c
diff --git a/src/java.desktop/share/native/libfontmanager/freetypeScaler.c
b/src/java.desktop/share/native/libfontmanager/freetypeScaler.c
Please exclude ALL 3rd party libraries from this PR.
-------------
PR: https://git.openjdk.java.net/jdk/pull/8328
