On Thu, 28 Apr 2022 21:25:02 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with 17 >> additional commits since the last revision: >> >> - Update src/java.desktop/windows/classes/sun/awt/windows/WPrinterJob.java >> >> Co-authored-by: Alexey Ivanov >> <70774172+aivanov-...@users.noreply.github.com> >> - Update src/java.desktop/unix/classes/sun/awt/X11/XBaseMenuWindow.java >> >> Co-authored-by: Alexey Ivanov >> <70774172+aivanov-...@users.noreply.github.com> >> - Update src/java.desktop/unix/classes/sun/awt/X11/XBaseMenuWindow.java >> >> Co-authored-by: Alexey Ivanov >> <70774172+aivanov-...@users.noreply.github.com> >> - Update src/java.desktop/share/classes/sun/swing/SwingUtilities2.java >> >> Co-authored-by: Alexey Ivanov >> <70774172+aivanov-...@users.noreply.github.com> >> - Update src/java.desktop/share/classes/sun/swing/SwingUtilities2.java >> >> Co-authored-by: Alexey Ivanov >> <70774172+aivanov-...@users.noreply.github.com> >> - Update src/java.desktop/share/classes/sun/awt/image/ImagingLib.java >> >> Co-authored-by: Alexey Ivanov >> <70774172+aivanov-...@users.noreply.github.com> >> - Update src/java.desktop/share/classes/sun/awt/image/ImagingLib.java >> >> Co-authored-by: Alexey Ivanov >> <70774172+aivanov-...@users.noreply.github.com> >> - Update >> src/java.desktop/share/classes/javax/swing/tree/FixedHeightLayoutCache.java >> >> Co-authored-by: Alexey Ivanov >> <70774172+aivanov-...@users.noreply.github.com> >> - Update >> src/java.desktop/share/classes/javax/swing/text/html/parser/TagStack.java >> >> Co-authored-by: Alexey Ivanov >> <70774172+aivanov-...@users.noreply.github.com> >> - Update src/java.desktop/share/classes/javax/swing/text/html/CSS.java >> >> Co-authored-by: Alexey Ivanov >> <70774172+aivanov-...@users.noreply.github.com> >> - ... and 7 more: >> https://git.openjdk.java.net/jdk/compare/40c585cd...98e635a5 > > Nearly 500 files are too many. Smaller chunks would be easier to review. > > Some of the native code files could come from upstream libraries. @aivanov-jdk While I approve of finding and fixing spelling mistakes, grammatical or semantic errors, the mistakes you posted suggestions for was not at all associated with the mechanical changes made by codespell that this PR included, and I assume you noticed them just because you read the text around the typo my PR fixed. In hindsight, it would have been better if you've made these changes yourself, in a separate PR. But since you had spent the effort of looking for these problems, and suggesting fixes, I have now accepted all of them. Due to how the Github UI works, this was quite tedious, so please refrain from submitting more than a handful suggestions next time you review a PR. ------------- PR: https://git.openjdk.java.net/jdk/pull/8328
