On Fri, 13 May 2022 16:53:31 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:

>> Nearly 500 files are too many. Smaller chunks would be easier to review.
>> 
>> Some of the native code files could come from upstream libraries.
>
> @aivanov-jdk While I approve of finding and fixing spelling mistakes, 
> grammatical or semantic errors, the mistakes you posted suggestions for was 
> not at all associated with the mechanical changes made by codespell that this 
> PR included, and I assume you noticed them just because you read the text 
> around the typo my PR fixed. 
> 
> In hindsight, it would have been better if you've made these changes 
> yourself, in a separate PR. 
> 
> But since you had spent the effort of looking for these problems, and 
> suggesting fixes, I have now accepted all of them. Due to how the Github UI 
> works, this was quite tedious, so please refrain from submitting more than a 
> handful suggestions next time you review a PR.

Thank you, @magicus,  I should've noted the changes and created a branch on top 
yours.

That's right. Even looking through all the changes in this PR was tedious, more 
than hundred files doesn't work well.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8328

Reply via email to