> This PR addresses a JCK test failure related to `DecimalFormatSymbols` > de-serialization. While the current public API of DFS disallows a null > locale, it was possible to set in the past. Thus, the > `loadNumberData(locale)` call currently throws NPE when locale is null in the > stream. The call should be guarded with a null check, such that if locale is > null, then `lenientMinusSigns` defaults to `minusSignText`. > > Defaulting the locale field when `null` to Locale.ROOT is also a reasonable > solution, but I think that the current one is preferable as a user would not > expect locale data related logic to occur if locale is `null`.
Justin Lu has updated the pull request incrementally with one additional commit since the last revision: public API is too broad ------------- Changes: - all: https://git.openjdk.org/jdk/pull/27008/files - new: https://git.openjdk.org/jdk/pull/27008/files/445bbe85..dfb818c7 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=27008&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=27008&range=02-03 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk/pull/27008.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/27008/head:pull/27008 PR: https://git.openjdk.org/jdk/pull/27008
