On Tue, 2 Sep 2025 21:21:04 GMT, Justin Lu <j...@openjdk.org> wrote: >> This PR addresses a JCK test failure related to `DecimalFormatSymbols` >> de-serialization. While the current public API of DFS disallows a null >> locale, it was possible to set in the past. Thus, the >> `loadNumberData(locale)` call currently throws NPE when locale is null in >> the stream. The call should be guarded with a null check, such that if >> locale is null, then `lenientMinusSigns` defaults to `minusSignText`. >> >> Defaulting the locale field when `null` to Locale.ROOT is also a reasonable >> solution, but I think that the current one is preferable as a user would not >> expect locale data related logic to occur if locale is `null`. > > Justin Lu has updated the pull request incrementally with one additional > commit since the last revision: > > public API is too broad
Thanks for adding a test, that will help catch any further regressions when changing this code. ------------- PR Comment: https://git.openjdk.org/jdk/pull/27008#issuecomment-3248859821
