On Fri, 29 Aug 2025 18:00:25 GMT, Justin Lu <j...@openjdk.org> wrote:
> This PR addresses a JCK test failure related to `DecimalFormatSymbols` > de-serialization. While the current public API of DFS disallows a null > locale, it was possible to set in the past. Thus, the > `loadNumberData(locale)` call currently throws NPE when locale is null in the > stream. The call should be guarded with a null check, such that if locale is > null, then `lenientMinusSigns` defaults to `minusSignText`. > > Defaulting the locale field when `null` to Locale.ROOT is also a reasonable > solution, but I think that the current one is preferable as a user would not > expect locale data related logic to occur if locale is `null`. This pull request has now been integrated. Changeset: e3b36e3b Author: Justin Lu <j...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/e3b36e3babb860d9d24a610160f47d42cfaafaa3 Stats: 266 lines in 2 files changed: 265 ins; 0 del; 1 mod 8366401: JCK test api/java_text/DecimalFormatSymbols/serial/InputTests.html fails after JDK-8363972 Reviewed-by: naoto ------------- PR: https://git.openjdk.org/jdk/pull/27008
