hi, On Tue, Mar 18, 2008 at 2:42 PM, Jean Delvare <[EMAIL PROTECTED]> wrote: > Hi Felipe, > > > On Sun, 16 Mar 2008 12:56:18 +0200, Felipe Balbi wrote: > > This patch uses set_irq_type as suggested by Dave. > > > > ============= CUT HERE ========= > > > > From 293a73277794a1ca0f2307e7fe9d5ecd76d3ad06 Mon Sep 17 00:00:00 2001 > > From: Felipe Balbi <[EMAIL PROTECTED]> > > Date: Tue, 1 Jan 2008 23:00:18 -0500 > > Subject: [PATCH] I2C: ISP1301_OMAP: New-style i2c driver updates, part 2 > > > > Based on David Brownell's patch for tps65010, this patch > > finish conversting isp1301_omap.c to new-style i2c driver. > > > > Signed-off-by: Felipe Balbi <[EMAIL PROTECTED]> > > --- > > arch/arm/mach-omap1/board-h2.c | 4 + > > arch/arm/mach-omap1/board-h3.c | 8 ++ > > arch/arm/mach-omap2/board-h4.c | 14 ++++ > > drivers/i2c/chips/isp1301_omap.c | 134 > ++++++++++--------------------------- > > 4 files changed, 62 insertions(+), 98 deletions(-) > > OK, I've applied this version of the patch. Note though that I am still > worried that it removed platform-specific code (in > isp1301_detach_client/isp1301_remove, isp1301_set_host and > isp1301_probe). The IRQ mode setting has moved to the board code, but > the rest has simply disappeared. I really would like you to confirm > that it is OK, or to send an updated patch if not.
The board specific code was regarding gpio interrupts, and we now get the correct gpio irq from i2c_board_info so when I free_irq() i'm already freeing the gpio, right ? -- Best Regards, Felipe Balbi [EMAIL PROTECTED] _______________________________________________ i2c mailing list [email protected] http://lists.lm-sensors.org/mailman/listinfo/i2c
