On Sun, Mar 16, 2008 at 12:56:18PM +0200, Felipe Balbi wrote: > This patch uses set_irq_type as suggested by Dave. > > ============= CUT HERE ========= > > >From 293a73277794a1ca0f2307e7fe9d5ecd76d3ad06 Mon Sep 17 00:00:00 2001 > From: Felipe Balbi <[EMAIL PROTECTED]> > Date: Tue, 1 Jan 2008 23:00:18 -0500 > Subject: [PATCH] I2C: ISP1301_OMAP: New-style i2c driver updates, part 2 > > Based on David Brownell's patch for tps65010, this patch > finish conversting isp1301_omap.c to new-style i2c driver. > > Signed-off-by: Felipe Balbi <[EMAIL PROTECTED]> > --- > arch/arm/mach-omap1/board-h2.c | 4 + > arch/arm/mach-omap1/board-h3.c | 8 ++ > arch/arm/mach-omap2/board-h4.c | 14 ++++ > drivers/i2c/chips/isp1301_omap.c | 134 ++++++++++--------------------------- > 4 files changed, 62 insertions(+), 98 deletions(-) > > diff --git a/arch/arm/mach-omap1/board-h2.c b/arch/arm/mach-omap1/board-h2.c > index 5079877..fd9567c 100644 > --- a/arch/arm/mach-omap1/board-h2.c > +++ b/arch/arm/mach-omap1/board-h2.c > @@ -22,6 +22,8 @@ > #include <linux/kernel.h> > #include <linux/platform_device.h> > #include <linux/delay.h> > +#include <linux/irq.h> > +#include <linux/interrupt.h> > #include <linux/i2c.h> > #include <linux/mtd/mtd.h> > #include <linux/mtd/nand.h> > @@ -366,6 +368,8 @@ static void __init h2_init_irq(void) > omap_init_irq(); > omap_gpio_init(); > h2_init_smc91x(); > + set_irq_type(OMAP_GPIO_IRQ(2), > + IRQF_SAMPLE_RANDOM | IRQF_TRIGGER_FALLING);
Calling set_irq_type directly is not the recommended way of doing this. Use the correct trigger flags to request_irq(). -- Ben ([EMAIL PROTECTED], http://www.fluff.org/) 'a smiley only costs 4 bytes' _______________________________________________ i2c mailing list [email protected] http://lists.lm-sensors.org/mailman/listinfo/i2c
