Moriah Waterland writes: > >> http://cr.opensolaris.org/~mwaterl/6739234.changes_only/webrev/ > Filed 6839397 libinst should be made a dynamic library > Please, see Note 1.
OK. > > 88: clean, clobber, and lint targets do not need .WAIT; only "all" > > does. > Removed the .WAIT as part of cleanup to address other code review > comments but I end up adding a dependency (Please see Note 2): > > $(CMDSUBDIRS): $(LIBSUBDIR) > The behavior of .WAIT is still present for the clean, clobber, and lint > targets but I am not addressing this issue further because my new fix is > maintainable, works correctly, and does not significantly contribute to > the overall run time for builds in the svr4pkg directory. OK. > > $(LIBSUBDIR) $(CMDSUBDIRS): FRC > > @cd $@; pwd; $(MAKE) $(TARGET) > > > Fixed this as part of addressing other comments about how I defined and > used the SUBDIR targets in svr4pkg/Makefile. My fix is as follows: Looks good. > Note 1. > ------ > I filed a bug to make libinst a dynamic library, but my assessment of > the likelihood of this actually being fixed is not encouraging. When you're done with this, would you be willing to review the fix? > You are correct regarding _msg target. I changed this so that I am not > even bothering with the additional effort to create a common .po file. > I changed the targets in each of the command subdirectories to be > $(MSGDOMAINPOFILE) Sounds good. > Note 3. > ----- > Although, there is a "clobber" target defined in > usr/src/cmd/Makefile.targ there is NOT a definition for "clean". I > removed all the definitions for clobber under svr4pkg and instead added > files to CLOBBERFILES += OK; that sounds right. -- James Carlson, Solaris Networking <james.d.carlson at sun.com> Sun Microsystems / 35 Network Drive 71.232W Vox +1 781 442 2084 MS UBUR02-212 / Burlington MA 01803-2757 42.496N Fax +1 781 442 1677
