>>> usr/src/lib/libpkg/common/p12lib.c >>> usr/src/lib/libpkg/common/p12lib.h >>> Please seek out legal help with this part. I don't think that >>> putting this code (which clearly belongs to someone else) under CDDL >>> is the right thing to do. The original Sun copyright notice >>> (without CDDL) was probably correct. >>> >>> Plus, you'll need to update the third party license files. >> Removed CDDL from both p12lib.c and p12lib.h. In usr/src/lib/libpkg, I >> created a THIRDPARTYLICENSE file and included the OpenSSL copyright and >> license as well as the AT&T copyright. I also created the >> THIRDPARTYLICENSE.descrip file. I modified the package definition for >> SUNWpkgcmdsu to include these licenses. > > OK. As long as you've had the necessary legal reviews and you've > followed the instructions in $SRC/README.license-files, I'm happy.
In particular, you will also need to update usr/src/tools/opensolaris/license-list to mention any new TPL files. >>> usr/src/pkgdefs/SUNWpkgcmdsu/prototype_com > [...] >>> 80: we typically don't ship compilation symlinks for internal >>> libraries. Will anything outside of ON compile against this? >> Eventually no, nothing outside of ON should compile against this. But, >> it is currently being used by projects in the new OpenSolaris installer: >> o http://src.opensolaris.org/source/xref/caiman/slim_source/ > > Oh. You might consider using a SUNWpkgcmdsint (internal) package to > deliver consolidation private objects. Moriah and I discussed this the other day, and I think she's leaning that way. It seems overkill for the compilation symlink, but she also expects to add more objects to such a package over time, as the slim install code is integrated in stages.