Moriah Waterland wrote: > Jim and Mark, > > FYI: here is a final webrev that includes my fixes for the last set of > comments: > http://cr.opensolaris.org/~mwaterl/svr4pkg.final/webrev/ > > -Moriah
usr/src/cmd/svr4pkg/libinst/Makefile.html: 29: LFLAGS should go away along with the other lex-related lines 66: POST_PROCESS_A shouldn't be part of the AR command line, it should come separately. It's somewhat academic, since the macro is empty, but it should be separate. usr/src/lib/libinstzones/Makefile, usr/src/lib/libpkg/Makefile: - You should not need to include usr/src/lib/Makefile.lib in either of these. MACH should come from the environment, and MAKE should expand to include "make -e," and you don't have anything else that's not self contained. usr/src/lib/libpkg/Makefile.com: 51: doh. 52-53: I might be confused now. But I thought you were using the "echo" command to pick up some header files that could not be derived directly from the object list. Since you're using "*.c" here, why not simply assign MSGFILES= $(OBJS:%.o=%.i)? Same question for libinstzones. That's all on this pass. These should be pretty easy. Let me know if anything didn't make sense, or you want to push back about changing any of them. --Mark
