<comments in-line> James Carlson wrote: > Moriah Waterland writes: >> I have generated a new webrev for: >> 6739234 move SVR4 packaging to ONNV gate >> >> This webrev includes the changes that I detailed in my responses to code >> review comments. >> >> Updated Webrev (2nd ed.): >> [http://cr.opensolaris.org/~mwaterl/6739234.changes_only.2/webrev/] > > I checked the .3 version of that webrev. > > usr/src/cmd/svr4pkg/pkgchk/main.c > > 135: unless my eyesight's going, it looks like 'h' (aitch) changed > to 'n' (enn) here and a bunch of random blank lines were added. Fixed this. Nope, isn't your eyes :)
> usr/src/pkgdefs/SUNWpkgcmdsu/Makefile > > 34-53: why is this so hard? Shouldn't it just be a series of echos > in a single build rule? (Is building a depend file always this hard > ... ?) I don't know of any other proper way to build a package specific depend file. Mark pointed me at a couple of packages that do this correctly: SUNWnfscr, SUNWsasnm. We need the grep so that we won't end up with duplicate dependencies if one of them is added to the common depend file. There is probably a clever way of accomplishing this with just one rule, but I didn't figure that there was a good ROI on figuring that out for this particular Makefile. > usr/src/lib/libpkg/common/llib-lpkg > > I'm not sure what this file is for. It doesn't have any content. > Well, I did a search for the header files in libpkg and found that 9 of the header files were included by code under usr/src/cmd/svr4pkg. I included the following files in llib-lpkg: cfext.h keystore.h nhash.h p12lib.h pkgerr.h pkglib.h pkglibmsgs.h pkglocale.h pkgweb.h I will be sending out the updated webrev later today. thanks, Moriah
