Moriah Waterland writes: > I have generated a new webrev for: > 6739234 move SVR4 packaging to ONNV gate > > This webrev includes the changes that I detailed in my responses to code > review comments. > > Updated Webrev (2nd ed.): > [http://cr.opensolaris.org/~mwaterl/6739234.changes_only.2/webrev/]
I checked the .3 version of that webrev. usr/src/cmd/svr4pkg/pkgchk/main.c 135: unless my eyesight's going, it looks like 'h' (aitch) changed to 'n' (enn) here and a bunch of random blank lines were added. usr/src/pkgdefs/SUNWpkgcmdsu/Makefile 34-53: why is this so hard? Shouldn't it just be a series of echos in a single build rule? (Is building a depend file always this hard ... ?) usr/src/lib/libpkg/common/llib-lpkg I'm not sure what this file is for. It doesn't have any content. > Jim, Mark, and Sundar: I would appreciate an explicit "ok" from each of > you before noon(PT) on Tuesday, May 26th. I'm otherwise ok with this. -- James Carlson, Solaris Networking <james.d.carlson at sun.com> Sun Microsystems / 35 Network Drive 71.232W Vox +1 781 442 2084 MS UBUR02-212 / Burlington MA 01803-2757 42.496N Fax +1 781 442 1677
