On Fri, 02 Jul 2010 11:54:44 -0400, Keith Packard <kei...@keithp.com> wrote:
> On Fri, 02 Jul 2010 09:24:07 +0100, Chris Wilson <ch...@chris-wilson.co.uk> 
> wrote:
> 
> > This looks like the responsibility of miCloseScreen(). Are we failing to
> > chain up properly?
> 
> I don't think miCloseScreen (or fbCloseScreen) can do this -- before
> we're called, rendering may not have been finished, after we're called,
> the acceleration code is shut down and pixmaps cannot be freed.

That sounds true, and deserves a comment in the code. It doesn't explain
why fbCloseScreen() calls free(screen->devPrivate) instead of
miCloseScreen() and causing the leak in the first place... :)
-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to