On Thu, 7 Apr 2011 15:04:14 -0700, Jesse Barnes <[email protected]> wrote: > On Thu, 07 Apr 2011 22:50:42 +0100 > Chris Wilson <[email protected]> wrote: > > One thing we need to be careful is to move the common code into small > > helper routines to avoid unnecessarily duplicating it. > > But not before we're sure about the duplication! Obviously things like > the workqueue init at IRQ install time could be shared,
Actually that workqueue init is in the wrong place entirely, but that was the sort of generic code I was looking at. ;-) > but I don't > like the idea of sharing hardware code unless it's absolutely > identical, given our history. Agreed, I think the model you've proposed of doing bring-up on a separate copy of the code and then gradually merge back the duplicate portions carries the least risk. Also looking at our history, we carry a lot of bugs that we only notice when looking at the next chipset iteration... -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
