On Mon, 19 Sep 2011 12:07:54 -0700, Ben Widawsky <[email protected]> wrote: > Signed-off-by: Ben Widawsky <[email protected]>
These are a nice set of cleanups and the extra fault reporting may come in handy. (I thought that fault register was to be used in conjunction with ppgtt in order for the gpu to fault in pages...) As Daniel mentioned we need to include the VCS for the acthd_stuck() check. I mentioned that I thought the general ERROR register was actually per-ring, but checking the specs I don't see it replicated. The only silly thing is that this introduces an array of register values for only some of the per-ring registers, hence a bit of inconsistency and just calling out for a complete overhaul of those per-ring structures and hopefully code reduction ;-) Per-ring per-gen hangcheck/error recording/error reporting may be useful. More likely overkill. ;-) -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
