On Sun, 30 Oct 2011 18:52:10 -0700, Ben Widawsky <[email protected]> wrote:
> Well, I had to pick one, and looking at the call chain, it seemed there wasn't > much to gain by doing retiring at this point. The point is that you're mixing the stuff the commit message talks about with other changes *which are not mentioned in the commit message* and which are *unrelated to the bug in question*. Two changes get two patches, it's pretty simple. And, commit messages must tell the whole truth and nothing but the truth. I really hate having to be this careful in reviewing your patches. -- [email protected]
pgplUhEBEzoiD.pgp
Description: PGP signature
_______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
