On Wed, 14 Dec 2011 13:57:05 +0100, Daniel Vetter <daniel.vet...@ffwll.ch> wrote: > We currently have 3 register for which we must not grab forcewake for: > FORCEWAKE, FROCEWAKE_MT and ECOBUS. > - FORCEWAKE is excluded in the NEEDS_FORCE_WAKE macro and accessed > with _NOTRACE. > - FORCEWAKE_MT is just accessed with _NOTRACE. > - ECOBUS is only excluded in the macro. > > In fear of an ever-growing list of special cases and to cut down the > confusion, just access all of them with the _NOTRACE variants.
Instead you build in future confusion by making us guess wtf is this using *_NOTRACE. The NOTRACE macro needs a bit of explanation as it now is more than simply skipping the tracepoints, and why certain registers must be accessed through the macro. Also add that warning to the register define. -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
