On Wed, 10 May 2017, Joonas Lahtinen <[email protected]> wrote:
> On ti, 2017-05-09 at 14:08 +0000, Michal Wajdeczko wrote:
>> We are using some scratch registers in MMIO based send function.
>> Make their base and count flexible in preparation of upcoming
>> GuC firmware/hardware changes. While around, change cmd len
>> parameter verification from WARN_ON to GEM_BUG_ON as we don't
>> need this all the time.
>> 
>> v2: call out WARN/GEM_BUG change in the commit msg (Daniele)
>> v3: don't overqualify the ints (Chris)
>> v4: rebase and use proper enum
>> 
>> Signed-off-by: Michal Wajdeczko <[email protected]>
>> Suggested-by: Daniele Ceraolo Spurio <[email protected]>
>> Cc: Daniele Ceraolo Spurio <[email protected]>
>> Cc: Joonas Lahtinen <[email protected]>
>> Cc: Chris Wilson <[email protected]>
>> Cc: Jani Nikula <[email protected]>
>> Reviewed-by: Daniele Ceraolo Spurio <[email protected]>
>
> I suppose this could've had "# v2" at the end, unless Daniele acked all
> the remaining changes.
>
> Anyway, looks good to me with the changes.
>
> Reviewed-by: Joonas Lahtinen <[email protected]>
>
> Could use an A-b from Jani for disagree and commit stamp as he
> initially objected the way of implementing this. 

Acked-by: Jani Nikula <[email protected]>



>
> Regards, Joonas

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to