On Mon, Sep 04, 2017 at 12:39:25PM +0200, Maarten Lankhorst wrote: > Op 31-08-17 om 20:48 schreef Ville Syrjälä: > > On Wed, Aug 30, 2017 at 09:57:03PM +0300, [email protected] > > wrote: > >> From: Ville Syrjälä <[email protected]> > >> > >> Make the min_pixclk thing less confusing by changing it to track > >> the minimum acceptable cdclk frequency instead. This means moving > >> the application of the guardbands to a slightly higher level from > >> the low level platform specific calc_cdclk() functions. > >> > >> The immediate benefit is elimination of the confusing 2x factors > >> on GLK/CNL+ in the audio workarounds (which stems from the fact > >> that the pipes produce two pixels per clock). > >> > >> v2: Keep cdclk higher on CNL to workaround missing DDI clock voltage > >> handling > >> v3: Squash with the CNL cdclk limits patch (DK) > >> v4: s/intel_min_cdclk/intel_pixel_rate_to_cdclk/ (DK) > >> > >> Cc: Paulo Zanoni <[email protected]> > >> Cc: Rodrigo Vivi <[email protected]> > >> Cc: Dhinakaran Pandiyan <[email protected]> > >> Cc: Maarten Lankhorst <[email protected]> > >> Reviewed-by: Dhinakaran Pandiyan <[email protected]> > >> Signed-off-by: Ville Syrjälä <[email protected]> > > I didn't get any objections from the CNL camp, so I went ahead and > > pushed the series. Thanks for the reviews. > > > I seem to have a WARN_ON during init now on my broadwell, likely related to > this series? > > [ 13.105310] i915 0000:00:02.0: vgaarb: changed VGA decodes: > olddecodes=io+mem,decodes=io+mem:owns=io+mem > [ 13.132264] systemd-journald[159]: Successfully sent stream file > descriptor to service manager. > [ 13.161016] WARN_ON(min_cdclk < 0)
Hmm. I think I need to see the full dmesg to figure this one out. -- Ville Syrjälä Intel OTC _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
