Quoting Gabriel Krisman Bertazi (2017-11-07 16:23:59) > Chris Wilson <[email protected]> writes: > > > Older compilers (gcc-4.9) are not as able to track uninitialised > > variables as well as more recent compilers. In particular, > > > > drivers/gpu/drm/i915/intel_dpio_phy.c: In function ‘bxt_ddi_phy_init’: > > drivers/gpu/drm/i915/intel_dpio_phy.c:482:25: warning: ‘was_enabled’ may be > > used uninitialized in this function [-Wmaybe-uninitialized] > > > > In this case, we can rearrange code slightly to make the control flow > > clearer to the reader, as well as the compiler. That is we only call > > uninit using the same predicate as calling init > > > > Signed-off-by: Chris Wilson <[email protected]> > > Cc: Ander Conselvan de Oliveira <[email protected]> > > Cc: Imre Deak <[email protected]> > > > Reviewed-by: Gabriel Krisman Bertazi <[email protected]>
Thanks for the review, pushed. -Chris _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
